Skip to content

fix: make stage has_module_graph_change calculate incorrectly#7920

Merged
JSerFeng merged 1 commit intomainfrom
jerry/has_module_graph_change
Sep 19, 2024
Merged

fix: make stage has_module_graph_change calculate incorrectly#7920
JSerFeng merged 1 commit intomainfrom
jerry/has_module_graph_change

Conversation

@jerrykingxyz
Copy link
Copy Markdown
Contributor

@jerrykingxyz jerrykingxyz commented Sep 18, 2024 •
edited
Loading

Summary

has_module_graph_change always evaluates to true when running update_module_graph multiple times during the make stage

fn make(compilation: &Compilation, make_artifact: MakeArtifact) {
  // run multi times
  let make_artifact = update_module_graph(compilation, make_artifact, params);
  let make_artifact = update_module_graph(compilation, make_artifact, params);
  assert_eq!(make_artifact.has_module_graph_change, true);
}

This PR rewrite the has_module_graph_change calculate by check make_artifact.built_module change.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Sep 18, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 18, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 531fe3a
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66eabc78b4fa5b0008c29dd4

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Sep 18, 2024
@jerrykingxyz jerrykingxyz force-pushed the jerry/has_module_graph_change branch from ab89b30 to a2f8c7e Compare September 18, 2024 11:34
@jerrykingxyz jerrykingxyz force-pushed the jerry/has_module_graph_change branch from a2f8c7e to 531fe3a Compare September 18, 2024 11:41
@JSerFeng JSerFeng merged commit 2164f12 into main Sep 19, 2024
@JSerFeng JSerFeng deleted the jerry/has_module_graph_change branch September 19, 2024 05:53
JSerFeng pushed a commit that referenced this pull request Sep 29, 2024
@jerrykingxyz @JSerFeng
fix: make stage has_module_graph_change calculate incorrectly (#7920)
5d88cbd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JSerFeng JSerFeng JSerFeng approved these changes

Assignees

@jerrykingxyz jerrykingxyz

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jerrykingxyz @JSerFeng