fix(core): use resource shouldn't contain query#7911
Merged
Conversation
✅ Deploy Preview for rspack canceled.
|
9b8702c to
3e46638
Compare
chenjiahan
reviewed
Sep 16, 2024
Member
chenjiahan
left a comment
There was a problem hiding this comment.
can we clarify this in the documentation
h-a-n-a
approved these changes
Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
align resource in use with webpack
the use resource(doesn't contain query) is actually misleading here because it has different meaning compared with loaderContext.resource(which contains query)
Checklist