feat: allow ModuleFactoryCreateData modify dependencies#7895
Merged
jerrykingxyz merged 1 commit intomainfrom Sep 14, 2024
Merged
feat: allow ModuleFactoryCreateData modify dependencies#7895jerrykingxyz merged 1 commit intomainfrom
jerrykingxyz merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rspack canceled.
|
3093e1b to
97ce0b3
Compare
ahabhgk
reviewed
Sep 13, 2024
ahabhgk
approved these changes
Sep 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently when factorize module we can only get first of dependencies and can not update them.
This PR will
ModuleFactoryCreateData.dependencytoModuleFactoryCreateData.dependenciesto make factorize hooks can access all dependencies.addtask so that updates to all dependencies are saved.Checklist