✅ Deploy Preview for rspack ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	5e758c9
🔍 Latest deploy log	https://app.netlify.com/sites/rspack/deploys/66ed3f370e9ef5000849ef63
😎 Deploy Preview	https://deploy-preview-7892--rspack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

          I introduced `DependencyRange` because some dependencies's `span` are only used as `range` and don't require `to_loc`. This approach reduces memory usage since `RealDependencyLocation` has an additional `source: Option<Arc<dyn SourceLocation>>`.

Originally posted by @shulaoda in #7871 (comment)

LGTM, cc @h-a-n-a

Do you have other purpose of introducing this data structure other than its size?

Do you have other purpose of introducing this data structure other than its size?

Perhaps it can be used as a substitute for ErrorSpan?

Do you have other purpose of introducing this data structure other than its size?

Perhaps it can be used as a substitute for ErrorSpan?

That's the question I was wondering. If we have ErrorSpan, why bother creating another DependencyRange? I'm still thinking about to unify these locations and ranges into RealDependencyLocation.

That's the question I was wondering. If we have ErrorSpan, why bother creating another DependencyRange? I'm still thinking about to unify these locations and ranges into RealDependencyLocation.

If an additional usize memory overhead is acceptable, we can do it this way. Alternatively, we could place the Sourcemap into the Dependency and use range.to_loc(self.sourcemap) for location transformation.

If an additional usize memory overhead is acceptable, we can do it this way.

I do think it's non-trivial. Let's keep RealDependencyLocation as small as 8-bytes.

Alternatively, we could place the Sourcemap into the Dependency and use range.to_loc(self.sourcemap) for location transformation.

Your suggestion sounds promising. Would you please give it a try?

Your suggestion sounds promising. Would you please give it a try?

I will complete it in the next PR. Additionally, I propose replacing RealDependencyLocation and SyntheticDependencyLocation with RealDependencyRange and SyntheticDependencyName respectively. Our implementation ultimately differs somewhat from Webpack.

Your suggestion sounds promising. Would you please give it a try?

I will complete it in the next PR. Additionally, I propose replacing RealDependencyLocation and SyntheticDependencyLocation with RealDependencyRange and SyntheticDependencyName respectively. Our implementation ultimately differs somewhat from Webpack.

LGTM. You could also replace name RealDependencyRange with DependencyRange and remove ErrorSpan. Both of them looks good to me.