refactor: css-extract using parseMeta to store css info#7878
Merged
Conversation
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ed0a4fc to
c4d5951
Compare
Member
|
Will fix: #7869 |
Contributor
|
Would you please add a test just to avoid regressions? |
c4d5951 to
800d008
Compare
Contributor
Author
Done |
h-a-n-a
approved these changes
Sep 12, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
css-extract uses
additionalDatato parse necessary data to Rust, butadditionalDatacan be removed by other user's plugin, so it's not safe.Now we introduce a new internal field for passing data, other loaders cannot modify it
Checklist