Skip to content

feat(rspack_plugin_javascript): improve provide dependency#7871

Merged
h-a-n-a merged 3 commits intoweb-infra-dev:mainfrom
shulaoda:feat/improve-provide-dependency
Sep 13, 2024
Merged

feat(rspack_plugin_javascript): improve provide dependency#7871
h-a-n-a merged 3 commits intoweb-infra-dev:mainfrom
shulaoda:feat/improve-provide-dependency

Conversation

@shulaoda
Copy link
Copy Markdown
Contributor

@shulaoda shulaoda commented Sep 12, 2024

Summary

Related to #7336 and #7422

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@shulaoda shulaoda marked this pull request as draft September 12, 2024 02:40
@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Sep 12, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 12, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 071fc9a
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66e3e7c4a279530008c8d4cd

@shulaoda shulaoda force-pushed the feat/improve-provide-dependency branch from 90957d9 to 12bbc53 Compare September 12, 2024 03:43
@shulaoda shulaoda marked this pull request as ready for review September 12, 2024 03:43
@shulaoda
Copy link
Copy Markdown
Contributor Author

shulaoda commented Sep 12, 2024

I introduced DependencyRange because some dependencies's span are only used as range and don't require to_loc. This approach reduces memory usage since RealDependencyLocation has an additional source: Option<Arc<dyn SourceLocation>>.

This was referenced Sep 12, 2024
Closed
Closed
@chenjiahan chenjiahan requested a review from h-a-n-a September 13, 2024 03:24
@h-a-n-a h-a-n-a merged commit 3343471 into web-infra-dev:main Sep 13, 2024
@shulaoda shulaoda deleted the feat/improve-provide-dependency branch September 13, 2024 08:21
@shulaoda shulaoda mentioned this pull request Sep 13, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@h-a-n-a h-a-n-a h-a-n-a approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release: feature release: feature related release(mr only)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shulaoda @h-a-n-a