Skip to content

fix: should provide full error message with error name when hideStack is set to true#7867

Merged
h-a-n-a merged 2 commits intomainfrom
fix-diagnostic
Sep 12, 2024
Merged

fix: should provide full error message with error name when hideStack is set to true#7867
h-a-n-a merged 2 commits intomainfrom
fix-diagnostic

Conversation

@h-a-n-a
Copy link
Copy Markdown
Contributor

@h-a-n-a h-a-n-a commented Sep 11, 2024 •
edited
Loading

Summary

Before

WARNING in ./lib.js
  ⚠ Failed to load (from: <PROJECT_ROOT>/tests/diagnosticsCases/module-build-failed/loader-emit-hide-stack/my-loader.js)

ERROR in ./lib.js
  × Failed to load (from: <PROJECT_ROOT>/tests/diagnosticsCases/module-build-failed/loader-emit-hide-stack/my-loader.js)

After

WARNING in ./lib.js
  ⚠ ModuleWarning: Failed to load (from: <PROJECT_ROOT>/tests/diagnosticsCases/module-build-failed/loader-emit-hide-stack/my-loader.js)

ERROR in ./lib.js
  × ModuleError: Failed to load (from: <PROJECT_ROOT>/tests/diagnosticsCases/module-build-failed/loader-emit-hide-stack/my-loader.js)

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Sep 11, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 11, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 3228af1
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66e2933a90b63600080aa79a

@h-a-n-a h-a-n-a requested a review from LingyuCoder September 11, 2024 10:56
@h-a-n-a h-a-n-a merged commit fa38b86 into main Sep 12, 2024
@h-a-n-a h-a-n-a deleted the fix-diagnostic branch September 12, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LingyuCoder LingyuCoder LingyuCoder approved these changes

Assignees

@h-a-n-a h-a-n-a

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@h-a-n-a @LingyuCoder