fix(external_module): use "const" if supported when concatenation#7836
Merged
fi3ework merged 1 commit intoweb-infra-dev:mainfrom Sep 10, 2024
Merged
fix(external_module): use "const" if supported when concatenation#7836fi3ework merged 1 commit intoweb-infra-dev:mainfrom
fi3ework merged 1 commit intoweb-infra-dev:mainfrom
Conversation
e2e3cc1 to
7ffd555
Compare
✅ Deploy Preview for rspack canceled.
|
✅ Deploy Preview for rspack canceled.
|
7ffd555 to
3df1980
Compare
Contributor
|
Note: We can safely use So its safe if don't have hoisting here So LGTM |
JSerFeng
approved these changes
Sep 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align with https://github.com/webpack/webpack/blob/039e8c96338ee98cf37d5035cdd30073a96b4ec5/lib/ExternalModule.js#L878. No coveraged test found in webpack.
Checklist