feat: support context for resolve and resolveWeak#7832
Merged
ahabhgk merged 5 commits intoweb-infra-dev:mainfrom Sep 10, 2024
Merged
feat: support context for resolve and resolveWeak#7832ahabhgk merged 5 commits intoweb-infra-dev:mainfrom
ahabhgk merged 5 commits intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
Contributor
|
LGTM，cc @ahabhgk |
ahabhgk
reviewed
Sep 9, 2024
Contributor
ahabhgk
left a comment
There was a problem hiding this comment.
Generally looks good to me, some nitpicks need change
crates/rspack_plugin_javascript/src/dependency/commonjs/require_resolve_dependency.rs
Outdated
Show resolved
Hide resolved
crates/rspack_plugin_javascript/src/parser_plugin/common_js_imports_parse_plugin.rs
Outdated
Show resolved
Hide resolved
crates/rspack_plugin_javascript/src/parser_plugin/common_js_imports_parse_plugin.rs
Outdated
Show resolved
Hide resolved
tests/webpack-test/cases/parsing/resolve-weak-context/test.filter.js
Outdated
Show resolved
Hide resolved
tests/webpack-test/cases/chunks/weak-dependencies-context/test.filter.js
Outdated
Show resolved
Hide resolved
ahabhgk
reviewed
Sep 10, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
close #7830 close #4315
Checklist