Skip to content

fix: should not transform source to buffer#7821

Merged
SyMind merged 4 commits intomainfrom
fix-trans-source-to-buffer
Sep 9, 2024
Merged

fix: should not transform source to buffer#7821
SyMind merged 4 commits intomainfrom
fix-trans-source-to-buffer

Conversation

@SyMind
Copy link
Copy Markdown
Member

@SyMind SyMind commented Sep 6, 2024 •
edited
Loading

Summary

Fix #7781

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Sep 6, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 6, 2024 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit c7caf66
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66daeb19700512000853944a
😎 Deploy Preview https://deploy-preview-7821--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SyMind SyMind marked this pull request as ready for review September 6, 2024 08:30
@web-infra-dev web-infra-dev deleted a comment from rspack-bot Sep 6, 2024
@SyMind
Copy link
Copy Markdown
Member Author

SyMind commented Sep 6, 2024

!bench

@rspack-bot
Copy link
Copy Markdown

rspack-bot commented Sep 6, 2024 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2024-09-06 d9a6d59) Current Change
10000_development-mode + exec 2.22 s ± 49 ms 2.23 s ± 27 ms +0.20 %
10000_development-mode_hmr + exec 681 ms ± 9.3 ms 699 ms ± 10 ms +2.58 %
10000_production-mode + exec 2.85 s ± 28 ms 2.84 s ± 27 ms -0.39 %
arco-pro_development-mode + exec 1.86 s ± 61 ms 1.84 s ± 55 ms -0.86 %
arco-pro_development-mode_hmr + exec 434 ms ± 3.7 ms 435 ms ± 2.1 ms +0.37 %
arco-pro_production-mode + exec 3.25 s ± 79 ms 3.27 s ± 83 ms +0.63 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.33 s ± 135 ms 3.3 s ± 76 ms -0.74 %
threejs_development-mode_10x + exec 1.67 s ± 19 ms 1.69 s ± 7.8 ms +1.11 %
threejs_development-mode_10x_hmr + exec 814 ms ± 10 ms 811 ms ± 4.4 ms -0.40 %
threejs_production-mode_10x + exec 5.17 s ± 35 ms 5.18 s ± 27 ms +0.34 %

@SyMind SyMind force-pushed the fix-trans-source-to-buffer branch from 00e3aa4 to 6622a82 Compare September 6, 2024 08:53
@SyMind SyMind changed the title fix: transform source to buffer fix: should not transform source to buffer Sep 6, 2024
@SyMind SyMind merged commit 0075187 into main Sep 9, 2024
@SyMind SyMind deleted the fix-trans-source-to-buffer branch September 9, 2024 09:07
@renovate renovate bot mentioned this pull request Oct 1, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees

@SyMind SyMind

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: runtime's source.source() does not return a string

3 participants

@SyMind @rspack-bot @ahabhgk