Skip to content

refactor: clean dev server code#7794

Merged
LingyuCoder merged 4 commits intomainfrom
feat/clean-dev-server
Sep 13, 2024
Merged

refactor: clean dev server code#7794
LingyuCoder merged 4 commits intomainfrom
feat/clean-dev-server

Conversation

@LingyuCoder
Copy link
Copy Markdown
Contributor

@LingyuCoder LingyuCoder commented Sep 4, 2024

Summary

  • should not override private methods, just add some alias
  • override the module.require.resolve in NodeModule instance of webpack-dev-server to redirect webpack server module request to rspack

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Sep 4, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 4, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 911033d
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66e3e6f7d8213d00083884b5

@LingyuCoder LingyuCoder marked this pull request as ready for review September 12, 2024 09:31
@LingyuCoder LingyuCoder enabled auto-merge (squash) September 12, 2024 09:49
@hardfist hardfist requested a review from ahabhgk September 13, 2024 02:50
ahabhgk
ahabhgk previously approved these changes Sep 13, 2024
Copy link
Copy Markdown
Contributor

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LingyuCoder LingyuCoder merged commit d7a15d8 into main Sep 13, 2024
@LingyuCoder LingyuCoder deleted the feat/clean-dev-server branch September 13, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants