feat(modern-module): make dynamic import runtime-less#7759
Merged
fi3ework merged 1 commit intoweb-infra-dev:mainfrom Sep 5, 2024
Merged
feat(modern-module): make dynamic import runtime-less#7759fi3ework merged 1 commit intoweb-infra-dev:mainfrom
fi3ework merged 1 commit intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
cdb0cb7 to
819b148
Compare
42 tasks
819b148 to
c73c237
Compare
ahabhgk
approved these changes
Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
modern-modulereduces the runtime code for external modules with dynamic import.What did this PR mainly do:
finish_moduleshook ofmodern-module, find allImportDependencydependencies that point to external modules.Concern:
The connection is revoked, does it need to add a new connection between the original module and external module with the new dependency, is there a proper method to do that?
Checklist