feat(rspack_plugin_schemas): http import schema plugin#7008
Merged
Conversation
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
5a68a80 to
948e244
Compare
216850f to
8decef9
Compare
c650fc9 to
aabf81f
Compare
d77760e to
201c858
Compare
af48a29 to
5d76766
Compare
ff8dff7 to
5e9c02c
Compare
# Conflicts: # Cargo.lock # crates/rspack_plugin_schemes/Cargo.toml
57471ee to
521b2c5
Compare
ahabhgk
approved these changes
Oct 8, 2024
Contributor
|
@ScriptedAlchemy should we expose this feature to js side? |
Contributor
Author
|
Yes, we should, but I have never done bindings for rspack and am not sure how this is accomplished. |
Contributor
|
we can merge this first and add binding and js side test in following pr，@SyMind can you help add jsbinding for this？ |
hardfist
approved these changes
Oct 10, 2024
Contributor
Author
|
@SyMind, would you tag me in the PR so I can read and understand it end-to-end? Then, next time, I'll try to create bindings on my own. 🙃 |
Contributor
Author
|
Yeah that's fine. My current use cases is with rust projects so I am not blocked by js. But user will want it for sure |
Member
|
@ScriptedAlchemy @hardfist I got it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the basic capabilities of HTTP URI Plugin
Example: https://github.com/ScriptedAlchemy/rspack-rust-api
Allows importing of esm http imports and bundling them
Checklist