refactor(core): remove unused exports final name metadata#14003
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Refactors NormalModule request fields to use Ustr interned strings to reduce repeated allocations/clones and centralize interning at module construction call sites.
Changes:
- Convert
NormalModule’srequest,user_request, andraw_requestfromStringtoUstrwith cacheable annotations. - Update
NormalModuleFactoryto pass internedUstrvalues intoNormalModule::new. - Replace
user_request_mutwithset_user_requestto ensure updates are re-interned.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/rspack_core/src/normal_module_factory.rs | Intern request strings before calling NormalModule::new, avoiding String cloning. |
| crates/rspack_core/src/normal_module.rs | Store request strings as Ustr, adjust accessors, and replace mutable accessor with a setter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📦 Binary Size-limit
🎉 Size decreased by 16.00KB from 61.97MB to 61.95MB (⬇️0.03%) |
Rsdoctor Bundle Diff AnalysisFound 6 projects in monorepo, 6 projects with changes. 📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 popular-libsPath:
📁 react-10kPath:
📁 react-1kPath:
📁 romePath:
📁 react-5kPath:
📁 ui-componentsPath:
Generated by Rsdoctor GitHub Action |
Merging this PR will not alter performance
Comparing 
Footnotes
|
3cc4ce2 to
74cba1b
Compare
Summary
exports_final_namemetadata from core module build metadata.exportsFinalNamefield from the binding API and generated napi types.Validation
cargo fmt --all --checkcargo check -p rspack_core -p rspack_binding_api --all-targets --locked