Skip to content

fix(ci): avoid browser e2e watcher#13987

Merged
hardfist merged 4 commits into
mainfrom
codex/ci-fd-usage-debug
May 11, 2026
Merged

fix(ci): avoid browser e2e watcher#13987
hardfist merged 4 commits into
mainfrom
codex/ci-fd-usage-debug

Conversation

@hardfist

@hardfist hardfist commented May 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Avoid the flaky browser e2e EMFILE failure by no longer starting Rsbuild's watch-based dev server in the Playwright webServer.

The browser e2e only needs to serve the built page once, so it now runs rsbuild build followed by rsbuild preview --port 8900. This avoids Chokidar/native watcher setup during CI and removes the temporary fd/ulimit debug logging from the workflow.

Related failure: https://github.com/web-infra-dev/rspack/actions/runs/25654958179/job/75302142464?pr=13984

Validation

  • git diff --check
  • Parsed .github/workflows/reusable-build-test.yml as YAML
  • Checked the browser e2e workflow script with bash -n after substituting the GitHub expression
  • CI validation is running on the latest pushed commit

Copilot AI review requested due to automatic review settings May 11, 2026 07:36
@hardfist hardfist requested a review from stormslowly as a code owner May 11, 2026 07:36
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed May 11, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e67a9f7d57

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/reusable-build-test.yml Outdated
Copilot AI reviewed May 11, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds best-effort file-descriptor (fd) diagnostics around the WASM browser E2E CI job to help debug intermittent EMFILE failures.

Changes:

  • Print host-side fd limits/usage at job start for the wasm32-wasip1-threads target.
  • Print container-side fd limits/usage before and after pnpm run test:e2e-browser.
  • Preserve the original E2E test exit code while still running the post-test probe.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/reusable-build-test.yml Outdated
Comment thread .github/workflows/reusable-build-test.yml Outdated
Comment thread .github/workflows/reusable-build-test.yml Outdated
Comment thread .github/workflows/reusable-build-test.yml
@github-actions

github-actions Bot commented May 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📦 Binary Size-limit

Comparing 7d8b40d to perf: reduce code splitter allocation and lookup overhead (#13968) by harpsealjs

🙈 Size remains the same at 61.96MB

@github-actions

github-actions Bot commented May 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Rsdoctor Bundle Diff Analysis

Found 6 projects in monorepo, 2 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB 0
react-5k 2.7 MB 0
react-1k 826.3 KB 0
popular-libs 1.7 MB +2.6 KB (0.1%)
rome 1.6 MB 0
ui-components 4.8 MB +14.0 B (0.0%)
📋 Detailed Reports (Click to expand)

📁 popular-libs

Path: ../build-tools-performance/cases/popular-libs/dist/rsdoctor-data.json

📌 Baseline Commit: fc1e4efbd0 | PR: #13968

Metric Current Baseline Change
📊 Total Size 1.7 MB 1.7 MB +2.6 KB (0.1%)
📄 JavaScript 1.7 MB 1.7 MB +2.6 KB (0.1%)
🎨 CSS 0 B 0 B 0
🌐 HTML 289.0 B 289.0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: popular-libs Bundle Diff

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

📌 Baseline Commit: fc1e4efbd0 | PR: #13968

Metric Current Baseline Change
📊 Total Size 4.8 MB 4.8 MB +14.0 B (0.0%)
📄 JavaScript 4.7 MB 4.7 MB +14.0 B (0.0%)
🎨 CSS 107.0 KB 107.0 KB 0
🌐 HTML 328.0 B 328.0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: ui-components Bundle Diff

Generated by Rsdoctor GitHub Action

@codspeed-hq

codspeed-hq Bot commented May 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 34 untouched benchmarks
⏩ 25 skipped benchmarks1

Comparing codex/ci-fd-usage-debug (7d8b40d) with main (fc1e4ef)

Open in CodSpeed

Footnotes

  1. 25 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@hardfist hardfist changed the title chore(ci): print fd usage for browser e2e fix(ci): raise nofile limit for browser e2e May 11, 2026
@github-actions github-actions Bot added the release: bug fix release: bug related release(mr only) label May 11, 2026
@hardfist hardfist enabled auto-merge (squash) May 11, 2026 11:25
@hardfist hardfist changed the title fix(ci): raise nofile limit for browser e2e fix(ci): avoid browser e2e watcher May 11, 2026
@hardfist hardfist disabled auto-merge May 11, 2026 12:12
@hardfist hardfist merged commit a5461e6 into main May 11, 2026
35 checks passed
@hardfist hardfist deleted the codex/ci-fd-usage-debug branch May 11, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@stormslowly stormslowly stormslowly approved these changes

Assignees

No one assigned

Labels

release: bug fix release: bug related release(mr only)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hardfist @stormslowly