docs(externals): add modern-module externals example#13979
Merged
JSerFeng merged 1 commit intoMay 11, 2026
Conversation
Timeless0911
approved these changes
May 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the externals configuration documentation to include an explicit externalsType: 'modern-module' example (in both EN and ZH), clarifying how externals are rendered when building output.library.type: 'modern-module' libraries and reinforcing the current requirement to opt in explicitly for compatibility.
Changes:
- Add a
modern-moduleexternals example to the English externals docs, covering staticimport, dynamicimport(), and CommonJSrequire()rendering. - Add the corresponding
modern-moduleexternals example to the Chinese externals docs with equivalent explanations and output illustration.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| website/docs/en/config/externals.mdx | Adds a concrete externalsType: 'modern-module' example and shows expected ESM output behavior for import styles. |
| website/docs/zh/config/externals.mdx | Mirrors the English update with a Chinese example and explanation of the same rendering behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
externalsType: 'modern-module'example in the EN/ZH externals docsimport(), and CommonJSrequire()externals render in modern-module outputChecks
pnpm exec prettier --check website/docs/en/config/externals.mdx website/docs/zh/config/externals.mdxpnpm --dir website run check:spellvia Node v22.21.1