docs: correct terminology spelling#13964
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes the spelling/casing of common ecosystem terminology across Rspack’s docs, type docs, diagnostics, and test fixtures to keep wording consistent (e.g., “ECMAScript”, “TypeScript”, “webpack”).
Changes:
- Normalize “EcmaScript” → “ECMAScript” in docs, config type comments, resolver hints, and parser diagnostics.
- Normalize “Typescript” → “TypeScript” in resolver/tsconfig option documentation across Rust, binding types, and generated d.ts.
- Normalize some “Webpack” mentions in comments/docs → “webpack”, and update related test fixtures/snapshots accordingly.
Reviewed changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| website/docs/zh/config/output.mdx | Doc comment casing fix for “ECMAScript” in output.environment. |
| website/docs/zh/blog/announcing-1-5.mdx | Fix “TypeScript” casing in Chinese blog post. |
| website/docs/zh/api/javascript-api/resolver.mdx | Use “webpack” casing in resolver API doc description text. |
| website/docs/en/config/output.mdx | Doc comment casing fix for “ECMAScript” in output.environment. |
| tests/rspack-test/normalCases/parsing/typeof-api/index.js | Comment terminology casing tweak (“webpack”). |
| tests/rspack-test/diagnosticsCases/module-parse-failed/tla_esm_error/stats.err | Update expected diagnostic text to “ECMAScript Modules”. |
| tests/rspack-test/diagnosticsCases/factorize/fully-specified-resolve-suggestions/stats.err | Update expected resolver hint text to “ECMAScript Module”. |
| tests/rspack-test/configCases/web/fetch-priority/index.js | Comment terminology casing tweak (“webpack”). |
| tests/rspack-test/configCases/resolver-factory/with-query/rspack.config.js | Comment terminology casing tweak (“webpack”). |
| tests/rspack-test/configCases/resolver-factory/with-fragment/rspack.config.js | Comment terminology casing tweak (“webpack”). |
| tests/rspack-test/configCases/resolver-factory/resolve/rspack.config.js | Comment terminology casing tweak (“webpack”). |
| packages/rspack/src/config/types.ts | Update public type docstrings to “ECMAScript Modules”. |
| packages/rspack/src/config/target.ts | Update target option description string to “ECMAScript”. |
| crates/rspack_plugin_javascript/src/parser_plugin/esm_detection_parser_plugin.rs | Update top-level-await error text to “ECMAScript Modules”. |
| crates/rspack_plugin_devtool/src/module_filename_helpers.rs | Comment terminology casing tweak (“webpack”). |
| crates/rspack_core/src/resolver/mod.rs | Update resolver hint text to “ECMAScript Module”. |
| crates/rspack_core/src/options/resolve/mod.rs | Update tsconfig option doc comment to “TypeScript”. |
| crates/rspack_binding_api/src/rspack_resolver/options.rs | Update binding option doc comment to “TypeScript”. |
| crates/node_binding/napi-binding.d.ts | Update generated TypeScript declaration doc comment to “TypeScript”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stormslowly
approved these changes
May 9, 2026
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 61.92MB |
Contributor
Rsdoctor Bundle Diff AnalysisFound 6 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR corrects terminology spelling across comments, diagnostics, type descriptions, and documentation so terms like
ECMAScript,TypeScript, andwebpackare written consistently.Checklist