chore: enable Rslint JS recommended rules #13938
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s JS/TS lint setup by enabling JavaScript “recommended” rules and adjusts parseTriple in the npm build script to avoid sparse-array destructuring while keeping the same target-triple parsing behavior.
Changes:
- Enable
js.configs.recommendedinrslint.config.ts(alongside TS recommended rules). - Refactor
parseTriple()inscripts/build-npm.cjsto avoid sparse array destructuring and keep ABI/sys extraction explicit.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/build-npm.cjs | Replaces sparse destructuring with explicit index access when parsing target triples. |
| rslint.config.ts | Adds JS recommended lint config and adjusts the config ordering/ignores list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 61.91MB |
Contributor
Rsdoctor Bundle Diff AnalysisFound 6 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Contributor
fansenze
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the lint configuration to include the JavaScript recommended rules and fixes the reported sparse array destructuring in the npm build script while preserving target triple parsing behavior.
Checklist