Skip to content

ci: upload codspeed valgrind temp files#13879

Merged
hardfist merged 1 commit into
mainfrom
codex/upload-codspeed-valgrind-tmp
May 7, 2026
Merged

ci: upload codspeed valgrind temp files#13879
hardfist merged 1 commit into
mainfrom
codex/upload-codspeed-valgrind-tmp

Conversation

@hardfist

@hardfist hardfist commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • route CodSpeed benchmark temporary files into a dedicated runner temp directory
  • upload the Valgrind temporary directory as a GitHub Actions artifact after the benchmark run
  • include a manifest so the artifact records the temp directory contents

Testing

  • ruby -e 'require "yaml"; YAML.load_file(".github/workflows/bench-rust.yml"); puts "bench-rust.yml OK"'

Note: local git hook was skipped for the commit because pnpm is not available in this shell PATH.

@github-actions github-actions Bot added the team The issue/pr is created by the member of Rspack. label Apr 29, 2026
@github-actions

github-actions Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

📦 Binary Size-limit

Comparing 64cf0a0 to feat(rslib): support emit isolated declarations (#13872) by Timeless0911

🙈 Size remains the same at 61.85MB

@github-actions

github-actions Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Rsdoctor Bundle Diff Analysis

Found 6 projects in monorepo, 6 projects with changes.

📊 Quick Summary
Project Total Size Change
popular-libs 1.7 MB -
react-10k 5.7 MB -
react-1k 826.1 KB -
rome 1.6 MB -
react-5k 2.7 MB -
ui-components 4.8 MB -
📋 Detailed Reports (Click to expand)

📁 popular-libs

Path: ../build-tools-performance/cases/popular-libs/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 1.7 MB - -
📄 JavaScript 1.7 MB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 5.7 MB - -
📄 JavaScript 5.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 826.1 KB - -
📄 JavaScript 826.1 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 1.6 MB - -
📄 JavaScript 1.6 MB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.7 MB - -
📄 JavaScript 2.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 4.8 MB - -
📄 JavaScript 4.7 MB - -
🎨 CSS 106.8 KB - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

Generated by Rsdoctor GitHub Action

@codspeed-hq

codspeed-hq Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 34 untouched benchmarks

Comparing codex/upload-codspeed-valgrind-tmp (64cf0a0) with main (9f97557)

Open in CodSpeed

@hardfist hardfist marked this pull request as ready for review April 29, 2026 13:43
@hardfist hardfist requested a review from stormslowly as a code owner April 29, 2026 13:43
@hardfist hardfist enabled auto-merge (squash) April 29, 2026 13:43
@hardfist hardfist merged commit 59e230e into main May 7, 2026
37 checks passed
@hardfist hardfist deleted the codex/upload-codspeed-valgrind-tmp branch May 7, 2026 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stormslowly stormslowly stormslowly approved these changes

Assignees

No one assigned

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hardfist @stormslowly