Skip to content

feat(backport): support regex flags and JavaScript lookaheads in extractComments condition#13437

Merged
CPunisher merged 1 commit intov1.xfrom
03-23-fix/swcjsminimizer-regex-support-v1.x
Mar 23, 2026
Merged

feat(backport): support regex flags and JavaScript lookaheads in extractComments condition#13437
CPunisher merged 1 commit intov1.xfrom
03-23-fix/swcjsminimizer-regex-support-v1.x

Conversation

@CPunisher
Copy link
Contributor

@CPunisher CPunisher commented Mar 23, 2026

Summary

backport #12990 to v1.x

Related links

closes #13431

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@hardfist @CPunisher
feat: support regex flags and JavaScript lookaheads in extractComment…
ed7fa3d 
…s condition (#12990)

* Initial plan

* Add regex flags support for extractComments condition

Co-authored-by: hardfist <8898718+hardfist@users.noreply.github.com>

* Add tests for regex flags support in extractComments

Co-authored-by: hardfist <8898718+hardfist@users.noreply.github.com>

* Address code review comments

Co-authored-by: hardfist <8898718+hardfist@users.noreply.github.com>

* fix: cargo fmt

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: hardfist <8898718+hardfist@users.noreply.github.com>
Co-authored-by: CPunisher <1343316114@qq.com>
chatgpt-codex-connector[bot]
chatgpt-codex-connector bot reviewed Mar 23, 2026
View reviewed changes
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ed7fa3d3f1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Mar 23, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2026

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 5 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB -
react-5k 2.7 MB -
react-1k 825.3 KB -
rome 984.2 KB -
ui-components 2.1 MB -
📋 Detailed Reports (Click to expand)

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 5.7 MB - -
📄 JavaScript 5.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.7 MB - -
📄 JavaScript 2.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 825.3 KB - -
📄 JavaScript 825.3 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 984.2 KB - -
📄 JavaScript 984.2 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.1 MB - -
📄 JavaScript 2.0 MB - -
🎨 CSS 83.0 KB - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2026

📦 Binary Size-limit

Comparing ed7fa3d to feat(rstest): support unmockRequire methods (#13412) by 9aoy

🎉 Size decreased by 698.48KB from 48.96MB to 48.28MB (⬇️1.39%)

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Mar 23, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 23, 2026

Merging this PR will degrade performance by 20.75%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

#### 🎉 Hooray! `codspeed-rust` just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

❌ 1 regressed benchmark
✅ 15 untouched benchmarks
⏩ 10 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation bundle@threejs-development 650.9 ms 821.3 ms -20.75%

Comparing 03-23-fix/swcjsminimizer-regex-support-v1.x (ed7fa3d) with main (fe84534)2

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on v1.x (c35857e) during the generation of this report, so main (fe84534) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@CPunisher CPunisher merged commit 066d273 into v1.x Mar 23, 2026
77 of 79 checks passed
@CPunisher CPunisher deleted the 03-23-fix/swcjsminimizer-regex-support-v1.x branch March 23, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@hardfist hardfist hardfist approved these changes

@quininer quininer Awaiting requested review from quininer quininer is a code owner

Assignees

No one assigned

Labels

release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CPunisher @hardfist