Skip to content

feat: add the map of json data size to rspack_plugin_rsdoctor for use rsdoctor#13194

Merged
yifancong merged 4 commits intov1.xfrom
feat/rsdoctor-get-json-size-v1
Mar 5, 2026
Merged

feat: add the map of json data size to rspack_plugin_rsdoctor for use rsdoctor#13194
yifancong merged 4 commits intov1.xfrom
feat/rsdoctor-get-json-size-v1

Conversation

@yifancong
Copy link
Copy Markdown
Contributor

@yifancong yifancong commented Mar 4, 2026 •
edited
Loading

Summary

Add the map of json data size to rspack_plugin_rsdoctor for use in rsdoctor.

This pull request introduces JSON module size collection and reporting in the Rsdoctor plugin, including post-tree-shaking sizes, with new data structures and a plugin hook to gather and integrate this data into the output. It also refactors asset collection for better readability and maintainability and improves inter-plugin integration by exposing necessary APIs and enhancing source map accuracy for JSON modules. These changes enhance module size analysis and asset reporting capabilities.

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@yifancong yifancong changed the title Feat/rsdoctor get json size v1 feat: add the map of json data size to rspack_plugin_rsdoctor for use rsdoctor Mar 4, 2026
@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Mar 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 4, 2026 •
edited
Loading

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 5 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB -
react-1k 825.3 KB -
react-5k 2.7 MB -
rome 984.2 KB -
ui-components 2.1 MB -
📋 Detailed Reports (Click to expand)

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 5.7 MB - -
📄 JavaScript 5.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 825.3 KB - -
📄 JavaScript 825.3 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.7 MB - -
📄 JavaScript 2.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 984.2 KB - -
📄 JavaScript 984.2 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.1 MB - -
📄 JavaScript 2.0 MB - -
🎨 CSS 83.0 KB - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 4, 2026 •
edited
Loading

📦 Binary Size-limit

Comparing d29e84f to chore(ci): update rsdoctor actions (#13192) by yifancong

🎉 Size decreased by 855.11KB from 48.91MB to 48.08MB (⬇️1.71%)

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 4, 2026 •
edited
Loading

Merging this PR will degrade performance by 15.08%

❌ 1 regressed benchmark
✅ 15 untouched benchmarks
⏩ 3 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ bundle@threejs-development 694.2 ms 817.5 ms -15.08%

Comparing feat/rsdoctor-get-json-size-v1 (d29e84f) with main (9b0ccf6)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on v1.x (72ecaf2) during the generation of this report, so main (9b0ccf6) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@yifancong yifancong marked this pull request as ready for review March 4, 2026 11:43
@yifancong yifancong requested a review from LingyuCoder as a code owner March 4, 2026 11:43
@yifancong yifancong merged commit ff45adf into v1.x Mar 5, 2026
55 checks passed
@yifancong yifancong deleted the feat/rsdoctor-get-json-size-v1 branch March 5, 2026 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LingyuCoder LingyuCoder LingyuCoder approved these changes

Assignees

No one assigned

Labels

release: feature release: feature related release(mr only)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yifancong @LingyuCoder