Skip to content

fix: port webpack fix for __webpack_module__ name collision for v1.x#12988

Merged
SyMind merged 1 commit intov1.xfrom
port-webpack-fix-to-rspark-v1
Feb 9, 2026
Merged

fix: port webpack fix for __webpack_module__ name collision for v1.x#12988
SyMind merged 1 commit intov1.xfrom
port-webpack-fix-to-rspark-v1

Conversation

@SyMind
Copy link
Copy Markdown
Member

@SyMind SyMind commented Feb 9, 2026 •
edited
Loading

Summary

cherry pick #12956 for Rspack v1.x

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings February 9, 2026 05:11
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Feb 9, 2026
@SyMind SyMind changed the title fix: port webpack fix for __webpack_module__ name collision fix: port webpack fix for __webpack_module__ name collision for v1.x Feb 9, 2026
@SyMind SyMind changed the base branch from main to v1.x February 9, 2026 05:12
@SyMind
fix: port webpack fix for __webpack_module__ name collision (#12956)
c7dab4d 
* Initial plan

* feat: port webpack fix for __webpack_module__ name collision

- Implement pre_declarator hook to detect 'module' variable declarations
- Implement pre_statement hook to detect 'module' function/class declarations
- Add test cases for collision scenarios

Co-authored-by: SyMind <19852293+SyMind@users.noreply.github.com>

* fix: use fixed internal variable names for consistency

Co-authored-by: SyMind <19852293+SyMind@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: SyMind <19852293+SyMind@users.noreply.github.com>
Co-authored-by: Cong-Cong <dacongsama@live.com>
@SyMind SyMind force-pushed the port-webpack-fix-to-rspark-v1 branch from a5684da to c7dab4d Compare February 9, 2026 05:12
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 9, 2026

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 5 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB -
react-1k 825.4 KB -
react-5k 2.7 MB -
ui-components 2.1 MB -
rome 984.2 KB -
📋 Detailed Reports (Click to expand)

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 5.7 MB - -
📄 JavaScript 5.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 825.4 KB - -
📄 JavaScript 825.4 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.7 MB - -
📄 JavaScript 2.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.1 MB - -
📄 JavaScript 2.0 MB - -
🎨 CSS 83.0 KB - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 984.2 KB - -
📄 JavaScript 984.2 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 9, 2026

📦 Binary Size-limit

Comparing c7dab4d to fix: port webpack fix for webpack_module name collision (#12956) by Copilot

🎉 Size decreased by 589.88KB from 48.59MB to 48.02MB (⬇️1.19%)

Copilot AI reviewed Feb 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Feb 9, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing port-webpack-fix-to-rspark-v1 (c7dab4d) with main (5e3f3b2)1

Summary

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark2

Footnotes

  1. No successful run was found on v1.x (40c1609) during the generation of this report, so main (5e3f3b2) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

@SyMind SyMind requested a review from Copilot February 9, 2026 05:41
Copilot AI reviewed Feb 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@SyMind SyMind merged commit c945d6f into v1.x Feb 9, 2026
55 checks passed
@SyMind SyMind deleted the port-webpack-fix-to-rspark-v1 branch February 9, 2026 06:11
@cursor
Copy link
Copy Markdown

cursor bot commented Feb 9, 2026

Skipping Bugbot: Bugbot is disabled for this repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@JSerFeng JSerFeng JSerFeng approved these changes

@LingyuCoder LingyuCoder Awaiting requested review from LingyuCoder

@hardfist hardfist Awaiting requested review from hardfist

@chenjiahan chenjiahan Awaiting requested review from chenjiahan

@ahabhgk ahabhgk Awaiting requested review from ahabhgk

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

@jerrykingxyz jerrykingxyz Awaiting requested review from jerrykingxyz

@stormslowly stormslowly Awaiting requested review from stormslowly

@quininer quininer Awaiting requested review from quininer

Assignees

No one assigned

Labels

release: bug fix release: bug related release(mr only)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SyMind @JSerFeng