Merged
Conversation
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR disables TypeScript ESLint warning-level rules in Rslint configuration to improve log readability. The changes are temporary, with plans to incrementally re-enable rules via issue #11761.
Key Changes:
- Disabled 24 TypeScript ESLint rules by changing their severity from "warn" to "off"
- Removed the
--max-warnings=2261flag from thelint:typescript
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rslint.json | Changed all TypeScript ESLint rule severities from "warn" to "off" to disable warnings |
| package.json | Removed --max-warnings flag from the lint:type script, allowing the command to pass without warning limits |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 47.62MB |
CodSpeed Performance ReportMerging #12243 will not alter performanceComparing Summary
|
hardfist
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently Rslint outputs too many warnings, which hurts log readability. This PR disables all the warning level rules to address this issue.
More rules will be enabled via #11761
Checklist