docs(config): improve module.defaultRules documentation#12230
Merged
chenjiahan merged 2 commits intomainfrom Nov 18, 2025
Merged
docs(config): improve module.defaultRules documentation#12230chenjiahan merged 2 commits intomainfrom
chenjiahan merged 2 commits intomainfrom
Conversation
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the documentation for module.defaultRules configuration option by providing clearer explanations and practical examples for developers working with Rspack's module resolution rules.
Key changes:
- Updated type definition from
Rule[]to(Rule | Falsy)[]to accurately reflect accepted values - Added comprehensive explanation of what default rules are and their purpose
- Included practical code examples demonstrating how to extend and remove default rules
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| website/docs/en/config/module.mdx | Enhanced English documentation with detailed explanation, usage examples, and updated source code reference (line #L453) |
| website/docs/zh/config/module.mdx | Enhanced Chinese documentation with corresponding translations, matching code examples, and updated source code reference (line #L453) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LingyuCoder
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarify the purpose and usage of
module.defaultRulesin documentation. Add examples for extending and removing default rules, and update the type definition to includeFalsyvalues.Checklist