test: disable iconv-lite decode warning in test tools#12217
Merged
LingyuCoder merged 1 commit intomainfrom Nov 17, 2025
Merged
Conversation
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes the suppression of iconv-lite decode warnings in the test tools package by creating a dedicated helper function that modifies the skipDecodeWarning property on all loaded iconv-lite modules in the require cache. This addresses console noise during testing.
- Creates a new
disableIconvLiteWarning()helper function that iterates throughrequire.cacheto find and configure iconv-lite modules - Invokes this helper at the module level in the test tools entry point (
index.ts)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
packages/rspack-test-tools/src/helper/disable-iconv-lite-warning.ts |
New helper function to suppress iconv-lite warnings by modifying modules in require.cache |
packages/rspack-test-tools/src/index.ts |
Calls the new helper at module initialization time |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 47.46MB |
CodSpeed Performance ReportMerging #12217 will not alter performanceComparing Summary
|
9aoy
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Can not find a better way to prevent emitting warning in iconv-lite.
Related links
Checklist