Conversation
✅ Deploy Preview for rspack canceled.
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes noplan test cases and fixes a bug in the system library name handling. The changes remove test cases that were previously marked as unsupported ("NOPLAN") or are now ready for testing. Additionally, it fixes the system library plugin to properly handle template placeholders (like [name], [id], [chunkhash]) in the library name configuration.
Key Changes
- Removed numerous test cases marked with "NOPLAN" (tests not planned for support or already passing but skipped)
- Updated system library plugin to resolve template strings in library names using
FilenameandPathData - Changed several test filters from "NOPLAN" to "TODO" or "FIXME" to indicate planned support
Reviewed Changes
Copilot reviewed 282 out of 419 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
crates/rspack_plugin_library/src/system_library_plugin.rs |
Fixed system library name to support template placeholders by using Filename and PathData |
tests/rspack-test/configCases/target/system-named-assets-path/test.filter.js |
Enabled test by removing NOPLAN filter |
tests/rspack-test/serialCases/css/css-modules-broken-keyframes/test.filter.js |
Changed filter from NOPLAN to TODO |
tests/rspack-test/exampleCases/cjs-tree-shaking/test.filter.js |
Changed filter from NOPLAN to TODO |
| Various test files in statsOutputCases, serialCases, normalCases, exampleCases, configCases | Removed entire test directories marked as NOPLAN |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/rspack-test/configCases/css/css-modules-broken-keyframes/test.filter.js
Show resolved
Hide resolved
📦 Binary Size-limit
❌ Size increased by 1.50KB from 47.46MB to 47.46MB (⬆️0.00%) |
CodSpeed Performance ReportMerging #12215 will not alter performanceComparing Summary
|
Summary
Related links
Checklist