test: test suite name should include base path#12214
Merged
Conversation
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes test suite naming to properly include the base path, enabling correct test selection when using the -t flag. The key change modifies how test suite names are constructed by using the actual source directory basename instead of the derived testId.
Key changes:
- Updated
@rstest/corefrom version 0.6.4 to 0.6.5 - Modified test suite naming logic to use the actual source directory basename
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/rspack-test-tools/src/helper/directory.ts | Changed test suite naming to use testSourceId (source directory basename) instead of testId, fixing test selection |
| package.json | Updated @rstest/core dependency from ^0.6.4 to ^0.6.5 |
| tests/rspack-test/package.json | Updated @rstest/core dependency from ^0.6.4 to ^0.6.5 |
| pnpm-lock.yaml | Updated lockfile to reflect new @rstest/core version and related dependencies |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 47.46MB |
CodSpeed Performance ReportMerging #12214 will not alter performanceComparing Summary
|
LingyuCoder
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix test
-t hotCases/asset/parser-and-generator-statesnot foundbefore:
after:
Related links
Checklist