Conversation
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the build script where Windows MSVC targets were not being correctly detected. The condition was using startsWith("windows-msvc") which would never match valid Rust target triples like x86_64-pc-windows-msvc, i686-pc-windows-msvc, or aarch64-pc-windows-msvc. The fix changes the check to use includes("windows-msvc") to properly identify all Windows MSVC targets.
- Changes the target detection logic from
startsWithtoincludesfor matching windows-msvc targets - Ensures the
-Cforce-unwind-tables=norustflag is correctly excluded for Windows MSVC builds
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 47.45MB |
CodSpeed Performance ReportMerging #12198 will not alter performanceComparing Summary
|
SyMind
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix ci
Related links
Checklist