fix: triple with windows-msvc doesn't support -Cforce-unwind-tables=no#12196
Merged
fix: triple with windows-msvc doesn't support -Cforce-unwind-tables=no#12196
Conversation
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR attempts to fix a compatibility issue where the Rust compiler flag -Cforce-unwind-tables=no is not supported on Windows MSVC targets. The change adds a conditional check to exclude this flag when building for windows-msvc platforms.
Key changes:
- Added conditional logic to check the target platform before applying the
-Cforce-unwind-tables=noflag during release builds - The flag is only applied if the target is set and doesn't start with "windows-msvc"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 47.45MB |
CodSpeed Performance ReportMerging #12196 will not alter performanceComparing Summary
|
529ea97 to
7a34794
Compare
SyMind
approved these changes
Nov 14, 2025
quininer
approved these changes
Nov 14, 2025
JSerFeng
added a commit
that referenced
this pull request
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Triple with windows-msvc doesn't support -Cforce-unwind-tables=no, need not use this rust flag in these triples
Related links
Checklist