Skip to content

chore(ci): support force use github artifacts#12187

Merged
hardfist merged 1 commit intomainfrom
chore/respect_download_force_github
Nov 13, 2025
Merged

chore(ci): support force use github artifacts#12187
hardfist merged 1 commit intomainfrom
chore/respect_download_force_github

Conversation

@stormslowly
Copy link
Copy Markdown
Contributor

@stormslowly stormslowly commented Nov 13, 2025 •
edited
Loading

Summary

In some cases (e.g. ecosystem bench ), we need to force the use of GitHub artifacts for better speed.

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: refactor labels Nov 13, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 13, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit e16bba4
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/6915aea191f5c90008133751

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 13, 2025 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2025-11-13 74ea720) Current Change
10000_big_production-mode_disable-minimize + exec 25.1 s ± 677 ms 24.9 s ± 409 ms -0.63 %
10000_development-mode + exec 1.31 s ± 21 ms 1.26 s ± 43 ms -3.47 %
10000_development-mode_hmr + exec 612 ms ± 5.4 ms 608 ms ± 24 ms -0.61 %
10000_development-mode_noop-loader + exec 2.24 s ± 65 ms 2.24 s ± 88 ms -0.16 %
10000_production-mode + exec 1.37 s ± 29 ms 1.35 s ± 10 ms -1.61 %
10000_production-mode_persistent-cold + exec 1.5 s ± 18 ms 1.47 s ± 16 ms -1.83 %
10000_production-mode_persistent-hot + exec 1.04 s ± 9.2 ms 1.02 s ± 26 ms -1.71 %
arco-pro_development-mode + exec 1.55 s ± 71 ms 1.59 s ± 82 ms +2.35 %
arco-pro_development-mode_hmr + exec 358 ms ± 0.39 ms 358 ms ± 0.83 ms -0.11 %
arco-pro_production-mode + exec 2.81 s ± 177 ms 2.85 s ± 115 ms +1.18 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 2.92 s ± 68 ms 2.95 s ± 139 ms +0.88 %
arco-pro_production-mode_persistent-cold + exec 2.97 s ± 70 ms 2.96 s ± 203 ms -0.30 %
arco-pro_production-mode_persistent-hot + exec 1.64 s ± 124 ms 1.65 s ± 62 ms +0.22 %
arco-pro_production-mode_traverse-chunk-modules + exec 2.87 s ± 117 ms 2.93 s ± 55 ms +2.10 %
large-dyn-imports_development-mode + exec 1.59 s ± 41 ms 1.58 s ± 40 ms -0.34 %
large-dyn-imports_production-mode + exec 1.61 s ± 52 ms 1.64 s ± 103 ms +1.71 %
threejs_development-mode_10x + exec 1.31 s ± 99 ms 1.28 s ± 12 ms -2.13 %
threejs_development-mode_10x_hmr + exec 909 ms ± 11 ms 915 ms ± 16 ms +0.65 %
threejs_production-mode_10x + exec 3.89 s ± 14 ms 3.91 s ± 171 ms +0.48 %
threejs_production-mode_10x_persistent-cold + exec 4.04 s ± 98 ms 3.98 s ± 49 ms -1.43 %
threejs_production-mode_10x_persistent-hot + exec 3.51 s ± 113 ms 3.48 s ± 28 ms -0.67 %
10000_big_production-mode_disable-minimize + rss memory 5371 MiB ± 192 MiB 5372 MiB ± 266 MiB +0.02 %
10000_development-mode + rss memory 579 MiB ± 35.8 MiB 589 MiB ± 47.7 MiB +1.63 %
10000_development-mode_hmr + rss memory 746 MiB ± 15.7 MiB 751 MiB ± 10.6 MiB +0.71 %
10000_development-mode_noop-loader + rss memory 885 MiB ± 33 MiB 868 MiB ± 35.1 MiB -1.99 %
10000_production-mode + rss memory 598 MiB ± 30.7 MiB 609 MiB ± 22.9 MiB +1.69 %
10000_production-mode_persistent-cold + rss memory 685 MiB ± 30.6 MiB 694 MiB ± 39.2 MiB +1.39 %
10000_production-mode_persistent-hot + rss memory 677 MiB ± 18.5 MiB 685 MiB ± 12 MiB +1.28 %
arco-pro_development-mode + rss memory 467 MiB ± 55.3 MiB 459 MiB ± 59.2 MiB -1.77 %
arco-pro_development-mode_hmr + rss memory 402 MiB ± 36.2 MiB 392 MiB ± 19.8 MiB -2.56 %
arco-pro_production-mode + rss memory 579 MiB ± 63.2 MiB 591 MiB ± 56.6 MiB +2.02 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 579 MiB ± 80.7 MiB 595 MiB ± 63 MiB +2.78 %
arco-pro_production-mode_persistent-cold + rss memory 656 MiB ± 59.7 MiB 633 MiB ± 41.2 MiB -3.58 %
arco-pro_production-mode_persistent-hot + rss memory 492 MiB ± 92.6 MiB 493 MiB ± 83.8 MiB +0.34 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 586 MiB ± 87.1 MiB 582 MiB ± 73.1 MiB -0.76 %
large-dyn-imports_development-mode + rss memory 610 MiB ± 3.36 MiB 609 MiB ± 7.46 MiB -0.20 %
large-dyn-imports_production-mode + rss memory 550 MiB ± 7.91 MiB 544 MiB ± 8.59 MiB -1.07 %
threejs_development-mode_10x + rss memory 535 MiB ± 32.2 MiB 527 MiB ± 23.1 MiB -1.38 %
threejs_development-mode_10x_hmr + rss memory 738 MiB ± 45.9 MiB 727 MiB ± 13.6 MiB -1.57 %
threejs_production-mode_10x + rss memory 690 MiB ± 129 MiB 706 MiB ± 63.1 MiB +2.34 %
threejs_production-mode_10x_persistent-cold + rss memory 745 MiB ± 60.2 MiB 738 MiB ± 58.7 MiB -0.98 %
threejs_production-mode_10x_persistent-hot + rss memory 599 MiB ± 28.6 MiB 606 MiB ± 57.8 MiB +1.21 %

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 13, 2025 •
edited
Loading

📦 Binary Size-limit

Comparing e16bba4 to fix: missing type of http proxy middleware options (#12188) by harpsealjs

❌ Size increased by 2.50KB from 47.45MB to 47.45MB (⬆️0.01%)

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Nov 13, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #12187 will not alter performance

Comparing chore/respect_download_force_github (e16bba4) with main (ccc95d7)

Summary

✅ 17 untouched

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 13, 2025 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2025-11-13 74ea720) Current Change
10000_big_production-mode_disable-minimize + exec 25.1 s ± 677 ms 25 s ± 678 ms -0.23 %
10000_development-mode + exec 1.31 s ± 21 ms 1.27 s ± 43 ms -3.36 %
10000_development-mode_hmr + exec 612 ms ± 5.4 ms 606 ms ± 12 ms -0.95 %
10000_development-mode_noop-loader + exec 2.24 s ± 65 ms 2.23 s ± 100 ms -0.64 %
10000_production-mode + exec 1.37 s ± 29 ms 1.35 s ± 70 ms -1.46 %
10000_production-mode_persistent-cold + exec 1.5 s ± 18 ms 1.47 s ± 15 ms -1.91 %
10000_production-mode_persistent-hot + exec 1.04 s ± 9.2 ms 1.02 s ± 42 ms -1.79 %
arco-pro_development-mode + exec 1.55 s ± 71 ms 1.61 s ± 133 ms +3.76 %
arco-pro_development-mode_hmr + exec 358 ms ± 0.39 ms 358 ms ± 0.83 ms +0.07 %
arco-pro_production-mode + exec 2.81 s ± 177 ms 2.85 s ± 164 ms +1.35 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 2.92 s ± 68 ms 2.99 s ± 119 ms +2.28 %
arco-pro_production-mode_persistent-cold + exec 2.97 s ± 70 ms 2.94 s ± 105 ms -0.87 %
arco-pro_production-mode_persistent-hot + exec 1.64 s ± 124 ms 1.64 s ± 75 ms -0.01 %
arco-pro_production-mode_traverse-chunk-modules + exec 2.87 s ± 117 ms 2.93 s ± 108 ms +2.18 %
large-dyn-imports_development-mode + exec 1.59 s ± 41 ms 1.56 s ± 27 ms -1.49 %
large-dyn-imports_production-mode + exec 1.61 s ± 52 ms 1.61 s ± 29 ms -0.37 %
threejs_development-mode_10x + exec 1.31 s ± 99 ms 1.28 s ± 23 ms -1.96 %
threejs_development-mode_10x_hmr + exec 909 ms ± 11 ms 911 ms ± 13 ms +0.17 %
threejs_production-mode_10x + exec 3.89 s ± 14 ms 3.86 s ± 49 ms -0.62 %
threejs_production-mode_10x_persistent-cold + exec 4.04 s ± 98 ms 4.03 s ± 165 ms -0.34 %
threejs_production-mode_10x_persistent-hot + exec 3.51 s ± 113 ms 3.49 s ± 32 ms -0.60 %
10000_big_production-mode_disable-minimize + rss memory 5371 MiB ± 192 MiB 5347 MiB ± 166 MiB -0.45 %
10000_development-mode + rss memory 579 MiB ± 35.8 MiB 582 MiB ± 31 MiB +0.46 %
10000_development-mode_hmr + rss memory 746 MiB ± 15.7 MiB 746 MiB ± 19.5 MiB +0.06 %
10000_development-mode_noop-loader + rss memory 885 MiB ± 33 MiB 865 MiB ± 48.4 MiB -2.31 %
10000_production-mode + rss memory 598 MiB ± 30.7 MiB 601 MiB ± 36.1 MiB +0.36 %
10000_production-mode_persistent-cold + rss memory 685 MiB ± 30.6 MiB 692 MiB ± 18.9 MiB +1.04 %
10000_production-mode_persistent-hot + rss memory 677 MiB ± 18.5 MiB 674 MiB ± 19.8 MiB -0.35 %
arco-pro_development-mode + rss memory 467 MiB ± 55.3 MiB 457 MiB ± 36.6 MiB -2.28 %
arco-pro_development-mode_hmr + rss memory 402 MiB ± 36.2 MiB 388 MiB ± 20.1 MiB -3.62 %
arco-pro_production-mode + rss memory 579 MiB ± 63.2 MiB 593 MiB ± 38.8 MiB +2.43 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 579 MiB ± 80.7 MiB 598 MiB ± 44 MiB +3.30 %
arco-pro_production-mode_persistent-cold + rss memory 656 MiB ± 59.7 MiB 644 MiB ± 77.4 MiB -1.88 %
arco-pro_production-mode_persistent-hot + rss memory 492 MiB ± 92.6 MiB 486 MiB ± 38.9 MiB -1.21 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 586 MiB ± 87.1 MiB 578 MiB ± 36.8 MiB -1.29 %
large-dyn-imports_development-mode + rss memory 610 MiB ± 3.36 MiB 607 MiB ± 7.92 MiB -0.47 %
large-dyn-imports_production-mode + rss memory 550 MiB ± 7.91 MiB 544 MiB ± 8.09 MiB -0.96 %
threejs_development-mode_10x + rss memory 535 MiB ± 32.2 MiB 528 MiB ± 15.8 MiB -1.24 %
threejs_development-mode_10x_hmr + rss memory 738 MiB ± 45.9 MiB 730 MiB ± 51.6 MiB -1.07 %
threejs_production-mode_10x + rss memory 690 MiB ± 129 MiB 708 MiB ± 128 MiB +2.60 %
threejs_production-mode_10x_persistent-cold + rss memory 745 MiB ± 60.2 MiB 757 MiB ± 27.7 MiB +1.64 %
threejs_production-mode_10x_persistent-hot + rss memory 599 MiB ± 28.6 MiB 617 MiB ± 71.9 MiB +3.03 %

@stormslowly stormslowly force-pushed the chore/respect_download_force_github branch from 86d7c29 to e16bba4 Compare November 13, 2025 10:10
@stormslowly stormslowly marked this pull request as ready for review November 13, 2025 10:14
Copilot AI review requested due to automatic review settings November 13, 2025 10:14
@stormslowly stormslowly changed the title refactor: respect force use github chore(ci): support force use github artifacts Nov 13, 2025
Copilot AI reviewed Nov 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for forcing the use of GitHub artifact downloads regardless of runner environment, enabling better speed in specific scenarios like ecosystem benchmarks.

Key changes:

  • Added force-use-github input parameter to the download artifact action
  • Updated conditional logic to respect the force flag when determining download source

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hardfist hardfist merged commit 8abe4b1 into main Nov 13, 2025
107 of 110 checks passed
@hardfist hardfist deleted the chore/respect_download_force_github branch November 13, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@hardfist hardfist hardfist approved these changes

Assignees

No one assigned

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stormslowly @hardfist