Conversation
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Rust nightly toolchain version to address a memory exhaustion issue caused by an endless loop when parsing Cargo.lock files with specific syntax errors, as documented in a known toml-rs issue.
- Updates Rust nightly channel from
nightly-2025-07-28tonightly-2025-11-13
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
🎉 Size decreased by 660.88KB from 48.10MB to 47.45MB (⬇️1.34%) |
CodSpeed Performance ReportMerging #12183 will not alter performanceComparing Summary
|
JSerFeng
commented
Nov 13, 2025
hardfist
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update rust toolchain.
In current version, if Cargo.lock has some specific syntax error, it may enter endless loop and run out of memory.
Known Issue: toml-rs/toml#1003
Related links
Checklist