fix: should transform output.path while emitting assets#12181
Merged
LingyuCoder merged 2 commits intomainfrom Nov 13, 2025
Merged
fix: should transform output.path while emitting assets#12181LingyuCoder merged 2 commits intomainfrom
output.path while emitting assets#12181LingyuCoder merged 2 commits intomainfrom
Conversation
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #11940 by ensuring that the output.path configuration is properly transformed (template placeholders like [fullhash] are replaced) before emitting assets and cleaning output directories.
Key Changes:
- Added a
From<&Utf8PathBuf>trait implementation forFilenameto support path-to-filename conversion - Modified
emit_assets()to transformoutput.pathtemplates before use and pass the transformed path to downstream functions - Updated
run_clean_options()to accept a transformedoutput_pathparameter for proper directory cleaning
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
tests/rspack-test/configCases/output/path-template/rspack.config.js |
Adds test to verify that template placeholders in output.path are transformed and literal placeholder names are not created as directories |
tests/rspack-test/configCases/output/path-template/index.js |
Minimal test entry point for the path template test case |
tests/rspack-test/Incremental-node.test.js |
Removes exclusion for rebuild-abnormal-module test, indicating the fix resolves a previously failing incremental build test |
crates/rspack_core/src/options/filename.rs |
Adds From trait implementation to convert Utf8PathBuf references into Filename for template processing |
crates/rspack_core/src/compiler/mod.rs |
Transforms output.path before emitting assets and passes the transformed path to cleaning and emission functions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
❌ Size increased by 1.75KB from 48.10MB to 48.10MB (⬆️0.00%) |
CodSpeed Performance ReportMerging #12181 will not alter performanceComparing Summary
|
output.path while emitting assets
ahabhgk
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix #11940
Related links
Checklist