test: can not handle uncaughtException correctly#12179
Merged
Conversation
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where uncaughtException and unhandledRejection events were not being handled correctly in tests. The previous implementation removed all listeners for these events, which broke proper error handling. The fix targets only the specific listeners added by the wast-loader package by removing just the last listener for each event type.
Key Changes:
- Replaced
process.removeAllListeners()calls with selective removal of the last listener foruncaughtExceptionandunhandledRejectionevents - Preserves other error handling listeners that may be registered by the test framework or other components
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 48.10MB |
CodSpeed Performance ReportMerging #12179 will not alter performanceComparing Summary
|
LingyuCoder
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix:
uncaughtExceptionwas not being handled correctly in tests because alluncaughtExceptionlisteners were removed.before:
after:
Related links
Checklist