Skip to content

chore: depreacte experiments.parallelCodeSplitting#12169

Merged
hardfist merged 2 commits intomainfrom
chore/deprecate-parallel-code-splitting
Nov 12, 2025
Merged

chore: depreacte experiments.parallelCodeSplitting#12169
hardfist merged 2 commits intomainfrom
chore/deprecate-parallel-code-splitting

Conversation

@JSerFeng
Copy link
Copy Markdown
Contributor

Summary

This options is depreacted, it has huge performance regression in some edge cases where the chunk graph has lots of cycles, we'll improve the performance of build_chunk_graph in the future instead.

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@JSerFeng JSerFeng requested a review from hardfist as a code owner November 12, 2025 07:25
Copilot AI review requested due to automatic review settings November 12, 2025 07:25
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 12, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 4e6ed34
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/69143ddf79613b0008221eb3
😎 Deploy Preview https://deploy-preview-12169--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

## experiments.parallelCodeSplitting

<ApiMeta addedVersion="1.2.0" />
<ApiMeta deprecatedVersion="1.6.2" />
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can move the deprecated options to the bottom of the page

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Nov 12, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR deprecates the experiments.parallelCodeSplitting configuration option due to severe performance regressions in edge cases involving chunk graphs with many cycles. The option will be removed in the next minor version.

Key Changes:

  • Added deprecation warnings to the runtime configuration validation
  • Updated documentation (English and Chinese) to reflect deprecation status
  • Added @deprecated JSDoc tags to TypeScript type definitions

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

File Description
website/docs/zh/config/experiments.mdx Updated Chinese documentation to show deprecation warning instead of info notice
website/docs/en/config/experiments.mdx Updated English documentation to show deprecation warning instead of info notice
packages/rspack/src/config/types.ts Added @deprecated JSDoc comment to the parallelCodeSplitting property
packages/rspack/src/config/normalization.ts Added runtime deprecation warning and JSDoc comment to normalized type

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JSerFeng JSerFeng force-pushed the chore/deprecate-parallel-code-splitting branch 2 times, most recently from ea71a4f to ebdaa38 Compare November 12, 2025 07:41
@JSerFeng JSerFeng force-pushed the chore/deprecate-parallel-code-splitting branch from a3276c6 to 4e6ed34 Compare November 12, 2025 07:57
@JSerFeng JSerFeng enabled auto-merge (squash) November 12, 2025 08:04
@github-actions
Copy link
Copy Markdown
Contributor

📦 Binary Size-limit

Comparing 4e6ed34 to refactor: move build_chunk_graph into compilation (#12162) by hardfist

🙈 Size remains the same at 48.09MB

@hardfist hardfist disabled auto-merge November 12, 2025 08:36
@hardfist hardfist merged commit e23f4cf into main Nov 12, 2025
41 checks passed
@hardfist hardfist deleted the chore/deprecate-parallel-code-splitting branch November 12, 2025 08:38
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Nov 12, 2025

CodSpeed Performance Report

Merging #12169 will not alter performance

Comparing chore/deprecate-parallel-code-splitting (4e6ed34) with main (0c06124)

Summary

✅ 17 untouched

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants