refactor: move compilation.rs to compilation folder#12159
Merged
Conversation
✅ Deploy Preview for rspack canceled.
|
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 48.09MB |
CodSpeed Performance ReportMerging #12159 will not alter performanceComparing Summary
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the code structure by moving compilation.rs from crates/rspack_core/src/compiler/compilation.rs to crates/rspack_core/src/compilation/mod.rs. This reorganization improves module organization and access control by giving compilation its own dedicated folder alongside the existing make submodule.
Key changes:
- Moved compilation implementation from compiler subfolder to its own top-level module
- Updated import paths across affected files to reference the new location
- Added
CompilationAssetto public exports for better API access
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
crates/rspack_core/src/compiler/compilation.rs |
Deleted - entire file content moved to compilation/mod.rs |
crates/rspack_core/src/compilation/mod.rs |
Added all compilation implementation code from the deleted file |
crates/rspack_core/src/compiler/mod.rs |
Updated imports to reference new compilation module location and added explicit Compilation/CompilationAsset imports |
crates/rspack_core/src/lib.rs |
Updated public exports to include all compilation items via wildcard export |
crates/rspack_core/src/plugin/mod.rs |
Updated CompilationId import path from crate::compiler to crate root |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stormslowly
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compilation should lie in compilation folder which support better access control
Related links
Checklist