Skip to content

perf: replace source and cached source#12110

Merged
ahabhgk merged 6 commits intomainfrom
perf-replace-source
Nov 10, 2025
Merged

perf: replace source and cached source#12110
ahabhgk merged 6 commits intomainfrom
perf-replace-source

Conversation

@SyMind
Copy link
Copy Markdown
Member

@SyMind SyMind commented Nov 7, 2025 •
edited
Loading

Summary

This PR updates the rspack_sources dependency version.

  1. fix: replace source for multi byte chars
  2. perf: ConcatSource source
  3. perf: remove rope
  4. fix: fixes UTF-16 encoding issues
  5. perf: replace source to original
  6. fix: replace size compute

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack. labels Nov 7, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 7, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit b005e5f
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/6911827465e9730008ecdc1c

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 7, 2025 •
edited
Loading

📦 Binary Size-limit

Comparing b005e5f to test: migrate rspack wasm test to rstest (#11990) by CPunisher

🎉 Size decreased by 19.63KB from 47.93MB to 47.91MB (⬇️0.04%)

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Nov 7, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #12110 will not alter performance

Comparing perf-replace-source (b005e5f) with main (2c12f2a)

Summary

✅ 17 untouched

@SyMind SyMind force-pushed the perf-replace-source branch 2 times, most recently from e6ebba0 to 0b03531 Compare November 8, 2025 13:32
@SyMind SyMind force-pushed the perf-replace-source branch from 0b03531 to 87c8934 Compare November 8, 2025 13:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 8, 2025 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2025-11-08 c12e9a0) Current Change
10000_big_production-mode_disable-minimize + exec 25.4 s ± 525 ms 25 s ± 513 ms -1.19 %
10000_development-mode + exec 1.34 s ± 28 ms 1.28 s ± 31 ms -4.42 %
10000_development-mode_hmr + exec 632 ms ± 13 ms 608 ms ± 15 ms -3.79 %
10000_development-mode_noop-loader + exec 2.24 s ± 46 ms 2.2 s ± 37 ms -1.51 %
10000_production-mode + exec 1.39 s ± 33 ms 1.35 s ± 20 ms -2.36 %
10000_production-mode_persistent-cold + exec 1.53 s ± 16 ms 1.52 s ± 133 ms -0.68 %
10000_production-mode_persistent-hot + exec 1.05 s ± 21 ms 1.04 s ± 36 ms -1.50 %
arco-pro_development-mode + exec 1.6 s ± 55 ms 1.59 s ± 57 ms -0.19 %
arco-pro_development-mode_hmr + exec 359 ms ± 0.62 ms 358 ms ± 3.3 ms -0.06 %
arco-pro_production-mode + exec 2.9 s ± 133 ms 2.85 s ± 78 ms -1.69 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 2.95 s ± 88 ms 2.92 s ± 57 ms -0.90 %
arco-pro_production-mode_persistent-cold + exec 2.97 s ± 107 ms 2.97 s ± 101 ms -0.09 %
arco-pro_production-mode_persistent-hot + exec 1.67 s ± 22 ms 1.64 s ± 41 ms -2.13 %
arco-pro_production-mode_traverse-chunk-modules + exec 2.91 s ± 87 ms 2.89 s ± 228 ms -0.56 %
large-dyn-imports_development-mode + exec 1.6 s ± 25 ms 1.6 s ± 73 ms -0.02 %
large-dyn-imports_production-mode + exec 1.62 s ± 48 ms 1.61 s ± 26 ms -0.44 %
threejs_development-mode_10x + exec 1.32 s ± 20 ms 1.27 s ± 15 ms -3.69 %
threejs_development-mode_10x_hmr + exec 923 ms ± 24 ms 900 ms ± 8.9 ms -2.54 %
threejs_production-mode_10x + exec 3.98 s ± 47 ms 3.9 s ± 124 ms -1.98 %
threejs_production-mode_10x_persistent-cold + exec 4.16 s ± 129 ms 4 s ± 57 ms -3.98 %
threejs_production-mode_10x_persistent-hot + exec 3.63 s ± 197 ms 3.5 s ± 50 ms -3.61 %
10000_big_production-mode_disable-minimize + rss memory 5776 MiB ± 31.2 MiB 5354 MiB ± 171 MiB -7.32 %
10000_development-mode + rss memory 588 MiB ± 13.3 MiB 583 MiB ± 21.4 MiB -0.90 %
10000_development-mode_hmr + rss memory 738 MiB ± 6.72 MiB 737 MiB ± 27.7 MiB -0.20 %
10000_development-mode_noop-loader + rss memory 887 MiB ± 51.3 MiB 883 MiB ± 44.2 MiB -0.52 %
10000_production-mode + rss memory 562 MiB ± 51.6 MiB 593 MiB ± 25.7 MiB +5.47 %
10000_production-mode_persistent-cold + rss memory 660 MiB ± 31.6 MiB 676 MiB ± 37.2 MiB +2.35 %
10000_production-mode_persistent-hot + rss memory 652 MiB ± 52.7 MiB 679 MiB ± 21.2 MiB +4.10 %
arco-pro_development-mode + rss memory 500 MiB ± 56.4 MiB 472 MiB ± 36.9 MiB -5.53 %
arco-pro_development-mode_hmr + rss memory 389 MiB ± 27.7 MiB 395 MiB ± 15.9 MiB +1.41 %
arco-pro_production-mode + rss memory 604 MiB ± 32.4 MiB 587 MiB ± 25.9 MiB -2.97 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 594 MiB ± 71 MiB 600 MiB ± 92.8 MiB +1.05 %
arco-pro_production-mode_persistent-cold + rss memory 678 MiB ± 41.3 MiB 661 MiB ± 98.8 MiB -2.49 %
arco-pro_production-mode_persistent-hot + rss memory 526 MiB ± 81.5 MiB 472 MiB ± 95.6 MiB -10.26 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 623 MiB ± 61.9 MiB 577 MiB ± 58.8 MiB -7.32 %
large-dyn-imports_development-mode + rss memory 613 MiB ± 5.61 MiB 611 MiB ± 8.94 MiB -0.45 %
large-dyn-imports_production-mode + rss memory 543 MiB ± 8.95 MiB 557 MiB ± 6.36 MiB +2.57 %
threejs_development-mode_10x + rss memory 534 MiB ± 18.4 MiB 529 MiB ± 26.3 MiB -0.84 %
threejs_development-mode_10x_hmr + rss memory 738 MiB ± 43.8 MiB 740 MiB ± 42.5 MiB +0.31 %
threejs_production-mode_10x + rss memory 753 MiB ± 168 MiB 668 MiB ± 93.7 MiB -11.21 %
threejs_production-mode_10x_persistent-cold + rss memory 785 MiB ± 31.3 MiB 722 MiB ± 41.3 MiB -7.99 %
threejs_production-mode_10x_persistent-hot + rss memory 633 MiB ± 17.3 MiB 595 MiB ± 48.6 MiB -5.98 %

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 9, 2025 •
edited
Loading

📝 Ecosystem CI detail: Open

suite result
modernjs ✅ success
rspress ✅ success
rstest ❌ failure
rsdoctor ✅ success
rslib ✅ success
devserver ✅ success
rsbuild ✅ success
plugin ❌ failure
lynx-stack ❌ failure
nuxt ✅ success
examples ✅ success

@web-infra-dev web-infra-dev deleted a comment from github-actions bot Nov 10, 2025
@web-infra-dev web-infra-dev deleted a comment from github-actions bot Nov 10, 2025
@web-infra-dev web-infra-dev deleted a comment from github-actions bot Nov 10, 2025
@SyMind SyMind marked this pull request as ready for review November 10, 2025 06:01
@SyMind SyMind requested a review from quininer as a code owner November 10, 2025 06:01
Copilot AI review requested due to automatic review settings November 10, 2025 06:01
Copilot AI reviewed Nov 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the rspack_sources dependency version and improves code formatting in documentation files.

  • Updates rspack_sources from version 0.4.14 to 0.4.15
  • Reformats multi-line code examples to single-line format in documentation

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
website/docs/zh/plugins/webpack/entry-plugin.mdx Reformats EntryPlugin code example to single line
website/docs/en/plugins/webpack/entry-plugin.mdx Reformats EntryPlugin code example to single line
Cargo.toml Updates rspack_sources dependency version to 0.4.15
Cargo.lock Updates rspack_sources version and checksum to match Cargo.toml

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@SyMind SyMind changed the title perf: replace source to original source perf: replace source and cached source Nov 10, 2025
quininer
quininer previously approved these changes Nov 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@quininer quininer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ahabhgk
ahabhgk previously approved these changes Nov 10, 2025
View reviewed changes
@ahabhgk ahabhgk enabled auto-merge (squash) November 10, 2025 06:12
@SyMind SyMind dismissed stale reviews from ahabhgk and quininer via b005e5f November 10, 2025 06:13
@ahabhgk ahabhgk merged commit 0273995 into main Nov 10, 2025
70 of 72 checks passed
@ahabhgk ahabhgk deleted the perf-replace-source branch November 10, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ahabhgk ahabhgk ahabhgk approved these changes

@quininer quininer quininer left review comments

Assignees

No one assigned

Labels

release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SyMind @quininer @ahabhgk