chore: remove divider comment from output#12109
Merged
chenjiahan merged 1 commit intomainfrom Nov 6, 2025
Merged
Conversation
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes visual separator comments (/************************************************************************/) from the generated JavaScript bundle output, resulting in cleaner and slightly smaller bundles.
Key Changes
- Removed three instances of separator comment additions in the JavaScript plugin rendering logic
- Updated all affected test snapshots to reflect the cleaner output format
- Bundle sizes decreased marginally due to the removal of these comment lines
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/rspack_plugin_javascript/src/plugin/mod.rs | Removed separator comment additions after webpack modules, header, and runtime modules sections |
| tests/rspack-test/statsOutputCases/worker-public-path/snapshots/stats.txt | Updated hash value reflecting output change |
| tests/rspack-test/statsOutputCases/warnings-space-warning/snapshots/stats.txt | Updated bundle size from 782 to 632 bytes |
| tests/rspack-test/statsOutputCases/split-chunks/snapshots/stats.txt | Updated entrypoint size from xx KiB to 9 KiB |
| tests/rspack-test/statsOutputCases/preset-none-error/snapshots/stats.txt | Updated bundle size from 924 to 774 bytes |
| tests/rspack-test/statsOutputCases/performance-no-async-chunks-shown/snapshots/stats.txt | Updated asset and entrypoint sizes to reflect separator removal |
| tests/rspack-test/statsOutputCases/max-external-module-readable-identifier/snapshots/stats.txt | Updated bundle size from xx KiB to 927 bytes |
| tests/rspack-test/statsOutputCases/external/snapshots/stats.txt | Updated bundle size from 998 to 848 bytes |
| tests/rspack-test/statsAPICases/chunk-group.js | Updated entrypoint size assertion from 13.6 KiB to 13.4 KiB |
| tests/rspack-test/hookCases/normalModuleFactory#resolve/resource/output.snap.txt | Removed separator comments from generated output |
| tests/rspack-test/hookCases/normalModuleFactory#afterResolve/resource/output.snap.txt | Removed separator comments from generated output |
| tests/rspack-test/hookCases/normalModuleFactory#afterResolve/request/output.snap.txt | Removed separator comments from generated output |
| tests/rspack-test/hookCases/normalModuleFactory#afterResolve/duplicate/output.snap.txt | Removed separator comments from generated output |
| tests/rspack-test/hookCases/javascriptModulesPlugin#chunkHash/update-hash/output.snap.txt | Removed separator comments from generated output |
| tests/rspack-test/hookCases/compiler#assetEmitted/basic/output.snap.txt | Removed separator comments from generated output |
| tests/rspack-test/hookCases/compilation#processAssets/update-asset/output.snap.txt | Updated hash and removed separator comments |
| tests/rspack-test/hookCases/compilation#chunkHash/update-hash/output.snap.txt | Removed separator comments from generated output |
| tests/rspack-test/hookCases/compilation#afterProcessAssets/basic/output.snap.txt | Removed separator comments from generated output |
| tests/rspack-test/configCases/rsdoctor/assets/rspack.config.js | Updated asset sizes from 4229 to 4004 bytes |
| tests/rspack-test/configCases/library/render-order-issue/snapshots/entry.mjs.txt | Removed separator comments from generated output |
| tests/rspack-test/configCases/library/modern-module-force-concaten/snapshot/g.js.txt | Removed separator comments from generated output |
| tests/rspack-test/configCases/library/modern-module-force-concaten/snapshot/f.js.txt | Removed separator comments from generated output |
| tests/rspack-test/configCases/library/modern-module-force-concaten/snapshot/e.js.txt | Removed separator comments from generated output |
| tests/rspack-test/configCases/library/modern-module-force-concaten/snapshot/b.js.txt | Removed separator comments from generated output |
| tests/rspack-test/builtinCases/plugin-html/variant/snapshots/output.snap.txt | Updated integrity hash reflecting output change |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
🎉 Size decreased by 512bytes from 47.89MB to 47.89MB (⬇️0.00%) |
CodSpeed Performance ReportMerging #12109 will not alter performanceComparing Summary
|
LingyuCoder
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the
/************************************************************************/divider comment from Rspack’s generated bundles to simplify the generated output.The comment originated from webpack's template as a visual separator. It has no functional or semantic purpose today.
Related links
Checklist