Merged
Conversation
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables previously skipped tests by fixing underlying issues related to test framework behavior and CSS handling. The main changes involve removing test filter files that were blocking test execution and adding missing configuration/test files.
- Removed filter files that were skipping tests due to resolved issues (global variable access, timeouts, and CSS error handling)
- Added configuration and test infrastructure for CSS dynamic loading tests
- Cleaned up extensive CSS test files that were likely redundant or moved to a different test structure
Reviewed Changes
Copilot reviewed 75 out of 143 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
tests/rspack-test/watchCases/runtime-requirements/entry-runtime-requirements/test.filter.js |
Removed test filter - issue with global variable access is fixed |
tests/rspack-test/watchCases/runtime-requirements/entry-runtime-requirements/rspack.config.js |
Added config to enable global variable with node.global: true |
tests/rspack-test/watchCases/runtime-requirements/entry-runtime-requirements/0/index.js |
Changed from temp to global variable reference |
tests/rspack-test/watchCases/resolve/in-loader/test.filter.js |
Enabled test by changing from error message to true |
tests/rspack-test/watchCases/resolve/in-loader/0/loader.js |
Added dependency tracking and commented duplicate code |
tests/rspack-test/watchCases/cache/add-defines/test.filter.js |
Changed from "FIXME" to "TODO" |
tests/rspack-test/watchCases/cache/add-defines/rspack.config.js |
Simplified cache configuration |
tests/rspack-test/statsOutputCases/track-returned/test.filter.js |
Changed from "FIXME" to "TODO" |
tests/rspack-test/serialCases/css/url/* |
Removed extensive CSS URL test files |
tests/rspack-test/serialCases/css/import/* |
Removed extensive CSS import test files |
tests/rspack-test/configCases/css/basic-dynamic-only/* |
Added new test case for dynamic CSS loading |
Comments suppressed due to low confidence (1)
tests/rspack-test/configCases/css/basic-dynamic-only/style.css:1
- The URL path references 'configCases/css/import/external.css', but the external.css file exists and the configCases directory structure exists. However, the URL scheme 'https://test.cases/root/' appears to be a test-specific mock URL. Verify that this mock URL is properly configured in the test infrastructure to resolve correctly, as this could cause test failures if the path resolution is not set up.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 47.89MB |
CodSpeed Performance ReportMerging #12106 will not alter performanceComparing Summary
|
9aoy
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable more test cases and remove some duplicated cases.
Related links
Checklist