Conversation
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a test case for handling the global identifier in web target with node options enabled. The test was previously marked as "FIXME" and is now working correctly.
- Adds
renamemethod toNodeStuffPluginto properly handle theglobalidentifier when it's being renamed - Removes the test filter that was blocking the test from running
- Cleans up import statements in the plugin file
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/rspack-test/configCases/web/node-source-global/test.filter.js | Removes the test filter that was blocking the test, allowing it to run now that the functionality is fixed |
| crates/rspack_plugin_javascript/src/parser_plugin/node_stuff_plugin.rs | Adds rename method to handle global identifier renaming and cleans up imports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
❌ Size increased by 768bytes from 47.87MB to 47.87MB (⬆️0.00%) |
CodSpeed Performance ReportMerging #12102 will not alter performanceComparing Summary
|
ahabhgk
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Should rename global variable to
__webpack_require__.gin node. Align with webapck.Related links
Checklist