fix(rstest): should only handles JavaScript module#12068
Merged
Conversation
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a guard to skip processing non-JavaScript assets in the rstest plugin's mock hoisting function.
- Adds early return when
info.javascript_moduleisNone, preventing the function from attempting to process non-JavaScript assets
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
❌ Size increased by 2.13KB from 47.86MB to 47.86MB (⬆️0.00%) |
CodSpeed Performance ReportMerging #12068 will not alter performanceComparing Summary
|
9aoy
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
for example, it will break WASM file as it's buffer source instead of string.
✗ wasm/index.test.ts (1) ✗ WASM factorial (1ms) WebAssembly.instantiate(): length overflow while decoding section length @+13 Summary of all failing tests: FAIL wasm/index.test.ts > WASM factorial CompileError: WebAssembly.instantiate(): length overflow while decoding section length @+13use traceable error instead of panic.
Related links
Checklist