test: migrate rspack wasm test to rstest#11990
Merged
Conversation
✅ Deploy Preview for rspack canceled.
|
3417a39 to
3ac4a9b
Compare
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 47.93MB |
CodSpeed Performance ReportMerging #11990 will not alter performanceComparing Summary
|
2 tasks
…-infra-dev/rspack into 10-23-chore/rstest-wasm-test
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves WASM test support, upgrades the test framework, and includes minor code quality improvements across documentation and test infrastructure.
- Upgrades
@rstest/corefrom^0.6.1to^0.6.3 - Adds comprehensive WASM test configuration with proper concurrency limits and test exclusions
- Improves error handling in hash test cases to provide more informative error messages
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| website/docs/zh/plugins/webpack/entry-plugin.mdx | Consolidates multi-line code example to single line for better readability |
| website/docs/en/plugins/webpack/entry-plugin.mdx | Consolidates multi-line code example to single line for better readability |
| tests/rspack-test/rstest.config.ts | Adds WASM-specific test configuration with appropriate test exclusions and concurrency settings |
| tests/rspack-test/package.json | Updates test scripts to use full binary path and upgrades @rstest/core version |
| pnpm-lock.yaml | Updates lockfile to reflect package version upgrades and new dependency additions |
| packages/rspack/src/ChunkGraph.ts | Updates parameter names in compareFn signature with underscore prefix |
| packages/rspack-test-tools/src/test/creator.ts | Adjusts WASM concurrency handling to use numeric value instead of boolean |
| packages/rspack-test-tools/src/helper/setup-env.ts | Removes legacy Jest compatibility code for WASM tests |
| packages/rspack-test-tools/src/case/hash.ts | Improves error messaging when stats are not found during hash test validation |
| package.json | Updates @rstest/core version in root package.json |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LingyuCoder
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related links
Checklist