fix: e2e lazy-compialtion/default-prefix flasky#11610
Merged
stormslowly merged 1 commit intomainfrom Sep 10, 2025
Merged
Conversation
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a flaky end-to-end test in the lazy-compilation/default-prefix test case by reordering code execution and improving test timing reliability.
- Moves button DOM insertion after event listener setup in the JavaScript source
- Reorders test actions to wait for lazy compilation response before triggering the click
- Adds explicit wait for button element before interaction
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/e2e/cases/lazy-compilation/default-prefix/src/index.js | Moves DOM insertion after event listener setup |
| tests/e2e/cases/lazy-compilation/default-prefix/index.test.ts | Reorders test flow and adds explicit waits to reduce flakiness |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 47.23MB |
CodSpeed Performance ReportMerging #11610 will not alter performanceComparing Summary
|
7fe0b41 to
432a638
Compare
SyMind
previously approved these changes
Sep 8, 2025
stormslowly
approved these changes
Sep 10, 2025
Contributor
|
let's try |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One of the e2e cases (lazy-compilation/default-prefix) has flasky, this may fix that
Related links
Checklist