fix: webpackexports comment#11597
Merged
LingyuCoder merged 10 commits intoweb-infra-dev:mainfrom Sep 10, 2025
Merged
Conversation
…-comment-webpackexports
✅ Deploy Preview for rspack ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
LingyuCoder
reviewed
Sep 10, 2025
Contributor
LingyuCoder
left a comment
There was a problem hiding this comment.
LGTM, the test cases should be added in tests/rspack-test. The test/webpack-test is using to migrate test cases from webpack and should not be modified.
Contributor
Author
|
Okay, let me update it. |
CodSpeed Performance ReportMerging #11597 will not alter performanceComparing Summary
|
Contributor
Author
|
Has updated |
|
棒棒哒 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If magic comments with webpackExports, the iterator will be finished, which causes the comments to remain and can't be collected.
Related links
#11583
Checklist