Skip to content

fix(mf): should disconnect chunk for removed chunk#11154

Merged
ahabhgk merged 2 commits intomainfrom
also-disconnect-chunk-for-removed-chunk
Jul 24, 2025
Merged

fix(mf): should disconnect chunk for removed chunk#11154
ahabhgk merged 2 commits intomainfrom
also-disconnect-chunk-for-removed-chunk

Conversation

@ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Jul 24, 2025 •
edited
Loading

Summary

fix #11152

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings July 24, 2025 04:37
@netlify
Copy link

netlify bot commented Jul 24, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit bdc3c1f
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/6881bbb10882d300083c4f43

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Jul 24, 2025
Copilot AI reviewed Jul 24, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the module federation plugin where chunks were not being properly disconnected before removal, which could lead to stale references in the chunk graph.

  • Ensures chunks are disconnected from the chunk graph before being removed
  • Restructures the chunk removal logic to handle the disconnect operation properly

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2025 •
edited
Loading

📦 Binary Size-limit

Comparing bdc3c1f to perf: napi communication (#11132) by Cong-Cong Pan

🎉 Size decreased by 512bytes from 49.01MB to 49.01MB (⬇️0.00%)

@ahabhgk ahabhgk enabled auto-merge (squash) July 24, 2025 04:52
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 24, 2025

CodSpeed Performance Report

Merging #11154 will not alter performance

Comparing also-disconnect-chunk-for-removed-chunk (bdc3c1f) with main (25000a7)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 16 untouched benchmarks

@ahabhgk ahabhgk merged commit 8f8d706 into main Jul 24, 2025
46 checks passed
@ahabhgk ahabhgk deleted the also-disconnect-chunk-for-removed-chunk branch July 24, 2025 05:08
@chenjiahan chenjiahan mentioned this pull request Jul 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ScriptedAlchemy ScriptedAlchemy ScriptedAlchemy approved these changes

@chenjiahan chenjiahan Awaiting requested review from chenjiahan

Assignees

No one assigned

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Version 1.4.9 is breaking Azure DevOps build pipelines

3 participants

@ahabhgk @ScriptedAlchemy