Skip to content

chore: degrade napi-build to 2.2.2#11130

Merged
CPunisher merged 2 commits intomainfrom
07-22-chore/napi-build
Jul 22, 2025
Merged

chore: degrade napi-build to 2.2.2#11130
CPunisher merged 2 commits intomainfrom
07-22-chore/napi-build

Conversation

@CPunisher
Copy link
Contributor

Summary

napi-build 3.0.0-beta.0 is yanked

Related links

https://crates.io/crates/napi-build/versions

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CPunisher CPunisher requested review from Copilot and hardfist July 22, 2025 09:47
@CPunisher CPunisher requested a review from quininer as a code owner July 22, 2025 09:47
@netlify
Copy link

netlify bot commented Jul 22, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 09dd033
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/687f5e66d45b0700087f50f1

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR downgrades the napi-build dependency from version 3.0.0-beta.0 to 2.2.2 because the beta version has been yanked from crates.io. The change ensures the project continues to build successfully by using a stable, available version of napi-build.

  • Downgraded napi-build from 3.0.0-beta.0 to 2.2.2 in Cargo.toml
  • Removed napi-build from the skip list in deny.toml configuration

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
Cargo.toml Updated napi-build version from yanked beta to stable 2.2.2
deny.toml Removed napi-build from dependency skip list

@CPunisher CPunisher force-pushed the 07-22-chore/napi-build branch from f607eb6 to 09dd033 Compare July 22, 2025 09:48
@CPunisher CPunisher enabled auto-merge (squash) July 22, 2025 09:49
@github-actions
Copy link
Contributor

📦 Binary Size-limit

Comparing 09dd033 to fix: add missing runtime globals in RUNTIME_GLOBAL_MAP (#11127) by Qingyu Wang

🎉 Size decreased by 384bytes from 48.95MB to 48.95MB (⬇️0.00%)

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 22, 2025

CodSpeed Performance Report

Merging #11130 will not alter performance

Comparing 07-22-chore/napi-build (09dd033) with main (a8645e8)

Summary

✅ 16 untouched benchmarks

@CPunisher CPunisher merged commit e1f8f4d into main Jul 22, 2025
44 checks passed
@CPunisher CPunisher deleted the 07-22-chore/napi-build branch July 22, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants