Skip to content

fix: environment.dynamicImport should affect chunkFormat and chunkLoading#10309

Merged
LingyuCoder merged 3 commits intomainfrom
fix/output-module-cases
May 9, 2025
Merged

fix: environment.dynamicImport should affect chunkFormat and chunkLoading#10309
LingyuCoder merged 3 commits intomainfrom
fix/output-module-cases

Conversation

@LingyuCoder
Copy link
Contributor

@LingyuCoder LingyuCoder commented May 9, 2025

Summary

Align with webpack, chunkFormat and chunkLoading should be set default value according to environment.dynamicImport

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@LingyuCoder LingyuCoder requested a review from fi3ework May 9, 2025 05:55
@netlify
Copy link

netlify bot commented May 9, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 7643475
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/681daf464187080008d86055

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels May 9, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented May 9, 2025

CodSpeed Performance Report

Merging #10309 will not alter performance

Comparing fix/output-module-cases (7643475) with main (4411873)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 11 untouched benchmarks

@LingyuCoder LingyuCoder force-pushed the fix/output-module-cases branch from 8ed46c4 to 7643475 Compare May 9, 2025 07:31
@LingyuCoder LingyuCoder enabled auto-merge (squash) May 9, 2025 08:30
@LingyuCoder LingyuCoder merged commit 489585f into main May 9, 2025
35 checks passed
@LingyuCoder LingyuCoder deleted the fix/output-module-cases branch May 9, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants