Skip to content

fix: parser generator arg validate#10298

Merged
ahabhgk merged 3 commits intomainfrom
fix/parse_generator_schema
May 8, 2025
Merged

fix: parser generator arg validate#10298
ahabhgk merged 3 commits intomainfrom
fix/parse_generator_schema

Conversation

@stormslowly
Copy link
Contributor

@stormslowly stormslowly commented May 8, 2025 •
edited
Loading

Summary

with an error parser generator config

module: {
  parser: {
    css: {
      url: true,
      banana: {}
    }
  },
  generator: {
    css: {
      url: true,
      banana: {}
    }
  }
}

before

rspack keeps slient

after

Invalid configuration object. Rspack has been initialized using a configuration object that does not match the API schema.
- Unrecognized key(s) in object: 'banana' at "module.parser.css"
- Unrecognized key(s) in object: 'url', 'banana' at "module.generator.css"
Error: Missing field `realpath`
...
  code: 'InvalidArg'

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented May 8, 2025 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit ff8dacf
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/681c84f94ea2e700083ac74b
😎 Deploy Preview https://deploy-preview-10298--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels May 8, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented May 8, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10298 will not alter performance

Comparing fix/parse_generator_schema (ff8dacf) with main (37e4827)

Summary

✅ 11 untouched benchmarks

@stormslowly stormslowly force-pushed the fix/parse_generator_schema branch from 6860ae4 to 8793bd0 Compare May 8, 2025 10:16
@stormslowly stormslowly requested review from ahabhgk and hardfist May 8, 2025 13:11
@ahabhgk ahabhgk merged commit 2e75d4f into main May 8, 2025
52 of 53 checks passed
@ahabhgk ahabhgk deleted the fix/parse_generator_schema branch May 8, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

@hardfist hardfist Awaiting requested review from hardfist hardfist is a code owner

Assignees

No one assigned

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stormslowly @ahabhgk