Skip to content

perf: import node inspector dynamically#10296

Merged
chenjiahan merged 1 commit intomainfrom
node_inspector_dynamic_0508
May 8, 2025
Merged

perf: import node inspector dynamically#10296
chenjiahan merged 1 commit intomainfrom
node_inspector_dynamic_0508

Conversation

@chenjiahan
Copy link
Member

Summary

Import node inspector module dynamically to:

  • Be compatible with Node.js that has been built with the --without-inspector flag.
  • Improve startup performance.

Related issue:

web-infra-dev/rsbuild#5193 (comment)

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@chenjiahan chenjiahan requested a review from hardfist May 8, 2025 08:23
@netlify
Copy link

netlify bot commented May 8, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 6e9f45c
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/681c6a11f919ae0008671dcd

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: performance release: performance related release(mr only) labels May 8, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented May 8, 2025

CodSpeed Performance Report

Merging #10296 will not alter performance

Comparing node_inspector_dynamic_0508 (6e9f45c) with main (e27eee3)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 11 untouched benchmarks

@chenjiahan chenjiahan merged commit 37e4827 into main May 8, 2025
87 of 93 checks passed
@chenjiahan chenjiahan deleted the node_inspector_dynamic_0508 branch May 8, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants