fix: copy zod types instead of bundling them#10222
Merged
chenjiahan merged 1 commit intomainfrom Apr 28, 2025
Merged
Conversation
✅ Deploy Preview for rspack canceled.
|
088c119 to
bfc0ee5
Compare
CodSpeed Performance ReportMerging #10222 will not alter performanceComparing 🎉 Hooray!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In #9899, I use default import to import
zodto make types clear like below.But if user use named import in daily development, the types will be emitted like:
And there exists an ast-grep issue when we try to redirect the import path, see ast-grep/ast-grep#1959
Since the named import is the recommended one, so this PR, we use named import to import zod uniformly, and modify the prebundle script to copy the dts file directly instead of using
rollup-plugin-dtsfor bundling to avoid the ast-grep issue and make the types simple and clear.Checklist