Skip to content

fix(core): temporarily disable lightningcss warning#10211

Merged
hardfist merged 4 commits intomainfrom
yj/disable-css-warning
Apr 28, 2025
Merged

fix(core): temporarily disable lightningcss warning#10211
hardfist merged 4 commits intomainfrom
yj/disable-css-warning

Conversation

@hardfist
Copy link
Contributor

Summary

temporarily disable lightningcss warning cause it contains too much positive-negative warnings

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@hardfist hardfist requested a review from JSerFeng as a code owner April 27, 2025 09:54
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 27, 2025
@netlify
Copy link

netlify bot commented Apr 27, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 5bdc4f0
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/680e08367b096e0008febd5a
😎 Deploy Preview https://deploy-preview-10211--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Apr 27, 2025
@chenjiahan chenjiahan requested a review from SyMind April 27, 2025 10:03
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 27, 2025

CodSpeed Performance Report

Merging #10211 will not alter performance

Comparing yj/disable-css-warning (5bdc4f0) with main (d71a6ab)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 11 untouched benchmarks

@hardfist hardfist enabled auto-merge (squash) April 27, 2025 10:48
@chenjiahan
Copy link
Member

Ref: #10162

And:

image

@hardfist hardfist merged commit 794447c into main Apr 28, 2025
34 checks passed
@hardfist hardfist deleted the yj/disable-css-warning branch April 28, 2025 02:14
@ItamarGronich
Copy link

ItamarGronich commented Sep 14, 2025

@hardfist Do you guys have plans to bring this back?
Good warnings can be beneficial and help devs improve code.
@chenjiahan

@chenjiahan
Copy link
Member

I believe we need to address negative warnings first, or provide an opt-in option to output warnings. @SyMind cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants